Support refactoring: Convert anonymous class to nested #1178
Conversation
Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
| @@ -111,6 +122,26 @@ private static PositionInformation getFirstTrackedNodePosition(LinkedProposalPos | |||
| return positions[0]; | |||
| } | |||
|
|
|||
| private static PositionInformation getFirstTrackedNodePositionBySequenceRank(LinkedProposalPositionGroupCore positionGroup) { | |||
There was a problem hiding this comment.
I think we should leverage the sequence rank information to get the first position in the position group.
If that is also the case in other proposals, we should avoid to get the first position by the array index since it's not reliable if any code refactor happens in the upstream side (jdt.core.manipulation)
There was a problem hiding this comment.
@jdneo ok so can you fix it in this PR?
There was a problem hiding this comment.
@fbricon How about addressing this in another PR?
Since I need some time to check if the sequence rank is also workable in the following proposals:
- extract varaible
- extract variable (all occurrence)
- extract constant
- extract method
- extract field
- invert variable
I can file another issue to track for this.
There was a problem hiding this comment.
@jdneo fine, you can open a separate issue
|
Thanks @jdneo ! |
Apologize that I forgot to create a new issue for this feature in advance. I just filed one here: #1177
Simple case:
A more complicated one:
client side PR: redhat-developer/vscode-java#1060
Signed-off-by: Sheng Chen [email protected]